Commit 5b400006 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Guenter Roeck
Browse files

hwmon: (vt8231) Convert to platform remove callback returning void 



The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230918085951.1234172-22-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 6e4c7baf

drivers/hwmon/vt8231.c

+2 −4
Original line number Diff line number Diff line
@@ -892,7 +892,7 @@ static int vt8231_probe(struct platform_device *pdev) 
	return err;

}



static int vt8231_remove(struct platform_device *pdev)

static void vt8231_remove(struct platform_device *pdev)

{

	struct vt8231_data *data = platform_get_drvdata(pdev);

	int i;
@@ -906,8 +906,6 @@ static int vt8231_remove(struct platform_device *pdev) 
		sysfs_remove_group(&pdev->dev.kobj, &vt8231_group_temps[i]);



	sysfs_remove_group(&pdev->dev.kobj, &vt8231_group);



	return 0;

}
@@ -916,7 +914,7 @@ static struct platform_driver vt8231_driver = { 
		.name	= DRIVER_NAME,

	},

	.probe	= vt8231_probe,

	.remove	= vt8231_remove,

	.remove_new = vt8231_remove,

};



static const struct pci_device_id vt8231_pci_ids[] = {