Commit 5b6fba54 authored by Damien Le Moal's avatar Damien Le Moal
Browse files

ata: libata-core: Detach a port devices on shutdown 



Modify ata_pci_shutdown_one() to schedule EH to unload a port devices
before freezing and thawing the port. This ensures that drives are
cleanly disabled and transitioned to standby power mode when
a PCI adapter is removed or the system is powered off.

Signed-off-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Tested-by: default avatarChia-Lin Kao (AceLan) <acelan.kao@canonical.com>
Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent cfead0dd

drivers/ata/libata-core.c

+15 −1
Original line number Diff line number Diff line
@@ -6164,10 +6164,24 @@ EXPORT_SYMBOL_GPL(ata_pci_remove_one); 
void ata_pci_shutdown_one(struct pci_dev *pdev)

{

	struct ata_host *host = pci_get_drvdata(pdev);

	struct ata_port *ap;

	unsigned long flags;

	int i;



	/* Tell EH to disable all devices */

	for (i = 0; i < host->n_ports; i++) {

		struct ata_port *ap = host->ports[i];

		ap = host->ports[i];

		spin_lock_irqsave(ap->lock, flags);

		ap->pflags |= ATA_PFLAG_UNLOADING;

		ata_port_schedule_eh(ap);

		spin_unlock_irqrestore(ap->lock, flags);

	}



	for (i = 0; i < host->n_ports; i++) {

		ap = host->ports[i];



		/* Wait for EH to complete before freezing the port */

		ata_port_wait_eh(ap);



		ap->pflags |= ATA_PFLAG_FROZEN;