Commit 5bd31ab5 authored by Shivaprasad G Bhat's avatar Shivaprasad G Bhat Committed by Michael Ellerman
Browse files

powerpc/iommu: Refactor spapr_tce_platform_iommu_attach_dev() 



The patch makes the iommu_group_get() call only when using it
thereby avoiding the unnecessary get & put for domain already
being set case.

Reviewed-by: default avatarJason Gunthorpe <jgg@nvidia.com>
Signed-off-by: default avatarShivaprasad G Bhat <sbhat@linux.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/170800513841.2411.13524607664262048895.stgit@linux.ibm.com
parent 39cd87c4

arch/powerpc/kernel/iommu.c

+3 −4
Original line number Diff line number Diff line
@@ -1285,15 +1285,14 @@ spapr_tce_platform_iommu_attach_dev(struct iommu_domain *platform_domain, 
				    struct device *dev)

{

	struct iommu_domain *domain = iommu_get_domain_for_dev(dev);

	struct iommu_group *grp = iommu_group_get(dev);

	struct iommu_table_group *table_group;

	struct iommu_group *grp;



	/* At first attach the ownership is already set */

	if (!domain) {

		iommu_group_put(grp);

	if (!domain)

		return 0;

	}



	grp = iommu_group_get(dev);

	table_group = iommu_group_get_iommudata(grp);

	/*

	 * The domain being set to PLATFORM from earlier