Commit 5c8764f8 authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: fix to force buffered IO on inline_data inode 



It will return all zero data when DIO reading from inline_data inode, it
is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly
for this case.

We can let iomap framework handle inline data via assigning iomap->type
and iomap->inline_data correctly, however, it will be a little bit
complicated when handling race case in between direct IO and buffered IO.

So, let's force to use buffered IO to fix this issue.

Cc: stable@vger.kernel.org
Reported-by: default avatarBarry Song <v-songbaohua@oppo.com>
Signed-off-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 6924c8b6

fs/f2fs/file.c

+2 −0
Original line number Diff line number Diff line
@@ -825,6 +825,8 @@ static bool f2fs_force_buffered_io(struct inode *inode, int rw) 
		return true;

	if (f2fs_compressed_file(inode))

		return true;

	if (f2fs_has_inline_data(inode))

		return true;



	/* disallow direct IO if any of devices has unaligned blksize */

	if (f2fs_is_multi_device(sbi) && !sbi->aligned_blksize)