Unverified Commit 5d0efaf4 authored by Peng Fan's avatar Peng Fan Committed by Mark Brown
Browse files

regulator: pca9450: Correct interrupt type 



Kernel warning on i.MX8MP-EVK when doing module test:
irq: type mismatch, failed to map hwirq-3 for gpio@30200000!

Per PCA945[X] specification: The IRQ_B pin is pulled low when any unmasked
interrupt bit status is changed and it is released high once application
processor read INT1 register.

So the interrupt should be configured as IRQF_TRIGGER_LOW, not
IRQF_TRIGGER_FALLING.

Fixes: 0935ff5f ("regulator: pca9450: add pca9450 pmic driver")
Signed-off-by: default avatarPeng Fan <peng.fan@nxp.com>
Link: https://patch.msgid.link/20260310-pca9450-irq-v1-1-36adf52c2c55@nxp.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 1f318b96

drivers/regulator/pca9450-regulator.c

+1 −1
Original line number Diff line number Diff line
@@ -1369,7 +1369,7 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) 
	if (pca9450->irq) {

		ret = devm_request_threaded_irq(pca9450->dev, pca9450->irq, NULL,

						pca9450_irq_handler,

						(IRQF_TRIGGER_FALLING | IRQF_ONESHOT),

						(IRQF_TRIGGER_LOW | IRQF_ONESHOT),

						"pca9450-irq", pca9450);

		if (ret != 0)

			return dev_err_probe(pca9450->dev, ret, "Failed to request IRQ: %d\n",