Commit 5d3ce4f7 authored by Hyunchul Lee's avatar Hyunchul Lee Committed by Jaegeuk Kim
Browse files

f2fs: avoid duplicated permission check for "trusted." xattrs 



Because xattr_permission already checks CAP_SYS_ADMIN
capability, we don't need to check it.

Signed-off-by: default avatarHyunchul Lee <cheol.lee@lge.com>
Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 7735730d

fs/f2fs/xattr.c

+0 −6
Original line number Diff line number Diff line
@@ -37,9 +37,6 @@ static int f2fs_xattr_generic_get(const struct xattr_handler *handler, 
			return -EOPNOTSUPP;

		break;

	case F2FS_XATTR_INDEX_TRUSTED:

		if (!capable(CAP_SYS_ADMIN))

			return -EPERM;

		break;

	case F2FS_XATTR_INDEX_SECURITY:

		break;

	default:
@@ -62,9 +59,6 @@ static int f2fs_xattr_generic_set(const struct xattr_handler *handler, 
			return -EOPNOTSUPP;

		break;

	case F2FS_XATTR_INDEX_TRUSTED:

		if (!capable(CAP_SYS_ADMIN))

			return -EPERM;

		break;

	case F2FS_XATTR_INDEX_SECURITY:

		break;

	default: