Commit 5d56b671 authored by Jaegeuk Kim's avatar Jaegeuk Kim
Browse files

f2fs: add an option to avoid unnecessary BUG_ONs 



If you want to remove unnecessary BUG_ONs, you can just turn off F2FS_CHECK_FS
in your kernel config.

Signed-off-by: default avatarJaegeuk Kim <jaegeuk.kim@samsung.com>
parent 3b218e3a

fs/f2fs/checkpoint.c

+5 −5
Original line number Diff line number Diff line
@@ -142,8 +142,8 @@ long sync_meta_pages(struct f2fs_sb_info *sbi, enum page_type type, 
		for (i = 0; i < nr_pages; i++) {

			struct page *page = pvec.pages[i];

			lock_page(page);

			BUG_ON(page->mapping != mapping);

			BUG_ON(!PageDirty(page));

			f2fs_bug_on(page->mapping != mapping);

			f2fs_bug_on(!PageDirty(page));

			clear_page_dirty_for_io(page);

			if (f2fs_write_meta_page(page, &wbc)) {

				unlock_page(page);
@@ -208,7 +208,7 @@ int acquire_orphan_inode(struct f2fs_sb_info *sbi) 
void release_orphan_inode(struct f2fs_sb_info *sbi)

{

	mutex_lock(&sbi->orphan_inode_mutex);

	BUG_ON(sbi->n_orphans == 0);

	f2fs_bug_on(sbi->n_orphans == 0);

	sbi->n_orphans--;

	mutex_unlock(&sbi->orphan_inode_mutex);

}
@@ -252,7 +252,7 @@ void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino) 
		if (orphan->ino == ino) {

			list_del(&orphan->list);

			kmem_cache_free(orphan_entry_slab, orphan);

			BUG_ON(sbi->n_orphans == 0);

			f2fs_bug_on(sbi->n_orphans == 0);

			sbi->n_orphans--;

			break;

		}
@@ -263,7 +263,7 @@ void remove_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino) 
static void recover_orphan_inode(struct f2fs_sb_info *sbi, nid_t ino)

{

	struct inode *inode = f2fs_iget(sbi->sb, ino);

	BUG_ON(IS_ERR(inode));

	f2fs_bug_on(IS_ERR(inode));

	clear_nlink(inode);



	/* truncate all the data during iput */

fs/f2fs/data.c

+2 −2
Original line number Diff line number Diff line
@@ -110,7 +110,7 @@ void update_extent_cache(block_t blk_addr, struct dnode_of_data *dn) 
	pgoff_t fofs, start_fofs, end_fofs;

	block_t start_blkaddr, end_blkaddr;



	BUG_ON(blk_addr == NEW_ADDR);

	f2fs_bug_on(blk_addr == NEW_ADDR);

	fofs = start_bidx_of_node(ofs_of_node(dn->node_page), fi) +

							dn->ofs_in_node;
@@ -436,7 +436,7 @@ static int get_data_block_ro(struct inode *inode, sector_t iblock, 
	}



	/* It does not support data allocation */

	BUG_ON(create);

	f2fs_bug_on(create);



	if (dn.data_blkaddr != NEW_ADDR && dn.data_blkaddr != NULL_ADDR) {

		int i;

fs/f2fs/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -139,7 +139,7 @@ static struct f2fs_dir_entry *find_in_level(struct inode *dir, 
	bool room = false;

	int max_slots = 0;



	BUG_ON(level > MAX_DIR_HASH_DEPTH);

	f2fs_bug_on(level > MAX_DIR_HASH_DEPTH);



	nbucket = dir_buckets(level);

	nblock = bucket_blocks(level);

fs/f2fs/f2fs.h

+14 −8
Original line number Diff line number Diff line
@@ -20,6 +20,12 @@ 
#include <linux/kobject.h>

#include <linux/sched.h>



#ifdef CONFIG_F2FS_CHECK_FS

#define f2fs_bug_on(condition)	BUG_ON(condition)

#else

#define f2fs_bug_on(condition)

#endif



/*

 * For mount options

 */
@@ -584,8 +590,8 @@ static inline int dec_valid_block_count(struct f2fs_sb_info *sbi, 
						blkcnt_t count)

{

	spin_lock(&sbi->stat_lock);

	BUG_ON(sbi->total_valid_block_count < (block_t) count);

	BUG_ON(inode->i_blocks < count);

	f2fs_bug_on(sbi->total_valid_block_count < (block_t) count);

	f2fs_bug_on(inode->i_blocks < count);

	inode->i_blocks -= count;

	sbi->total_valid_block_count -= (block_t)count;

	spin_unlock(&sbi->stat_lock);
@@ -717,9 +723,9 @@ static inline void dec_valid_node_count(struct f2fs_sb_info *sbi, 
{

	spin_lock(&sbi->stat_lock);



	BUG_ON(sbi->total_valid_block_count < count);

	BUG_ON(sbi->total_valid_node_count < count);

	BUG_ON(inode->i_blocks < count);

	f2fs_bug_on(sbi->total_valid_block_count < count);

	f2fs_bug_on(sbi->total_valid_node_count < count);

	f2fs_bug_on(inode->i_blocks < count);



	inode->i_blocks -= count;

	sbi->total_valid_node_count -= count;
@@ -740,7 +746,7 @@ static inline unsigned int valid_node_count(struct f2fs_sb_info *sbi) 
static inline void inc_valid_inode_count(struct f2fs_sb_info *sbi)

{

	spin_lock(&sbi->stat_lock);

	BUG_ON(sbi->total_valid_inode_count == sbi->total_node_count);

	f2fs_bug_on(sbi->total_valid_inode_count == sbi->total_node_count);

	sbi->total_valid_inode_count++;

	spin_unlock(&sbi->stat_lock);

}
@@ -748,7 +754,7 @@ static inline void inc_valid_inode_count(struct f2fs_sb_info *sbi) 
static inline int dec_valid_inode_count(struct f2fs_sb_info *sbi)

{

	spin_lock(&sbi->stat_lock);

	BUG_ON(!sbi->total_valid_inode_count);

	f2fs_bug_on(!sbi->total_valid_inode_count);

	sbi->total_valid_inode_count--;

	spin_unlock(&sbi->stat_lock);

	return 0;
@@ -769,7 +775,7 @@ static inline void f2fs_put_page(struct page *page, int unlock) 
		return;



	if (unlock) {

		BUG_ON(!PageLocked(page));

		f2fs_bug_on(!PageLocked(page));

		unlock_page(page);

	}

	page_cache_release(page);

fs/f2fs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -296,7 +296,7 @@ static int truncate_blocks(struct inode *inode, u64 from) 
		count = ADDRS_PER_BLOCK;



	count -= dn.ofs_in_node;

	BUG_ON(count < 0);

	f2fs_bug_on(count < 0);



	if (dn.ofs_in_node || IS_INODE(dn.node_page)) {

		truncate_data_blocks_range(&dn, count);