Commit 5d90492d authored by Oleksij Rempel's avatar Oleksij Rempel Committed by David S. Miller
Browse files

net: dsa: microchip: ksz8: fix ksz8_fdb_dump() to extract all 1024 entries 



Current ksz8_fdb_dump() is able to extract only max 249 entries on
the ksz8863/ksz8873 series of switches. This happened due to wrong
bit mask and offset calculation.

This commit corrects the issue and allows for the complete extraction of
all 1024 entries.

Fixes: 4b20a07e ("net: dsa: microchip: ksz8795: add support for ksz88xx chips")
Signed-off-by: default avatarOleksij Rempel <o.rempel@pengutronix.de>
Acked-by: default avatarArun Ramadoss <arun.ramadoss@microchip.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 88e943e8

drivers/net/dsa/microchip/ksz_common.c

+3 −3
Original line number Diff line number Diff line
@@ -407,10 +407,10 @@ static const u32 ksz8863_masks[] = { 
	[STATIC_MAC_TABLE_FID]		= GENMASK(29, 26),

	[STATIC_MAC_TABLE_OVERRIDE]	= BIT(20),

	[STATIC_MAC_TABLE_FWD_PORTS]	= GENMASK(18, 16),

	[DYNAMIC_MAC_TABLE_ENTRIES_H]	= GENMASK(5, 0),

	[DYNAMIC_MAC_TABLE_ENTRIES_H]	= GENMASK(1, 0),

	[DYNAMIC_MAC_TABLE_MAC_EMPTY]	= BIT(7),

	[DYNAMIC_MAC_TABLE_NOT_READY]	= BIT(7),

	[DYNAMIC_MAC_TABLE_ENTRIES]	= GENMASK(31, 28),

	[DYNAMIC_MAC_TABLE_ENTRIES]	= GENMASK(31, 24),

	[DYNAMIC_MAC_TABLE_FID]		= GENMASK(19, 16),

	[DYNAMIC_MAC_TABLE_SRC_PORT]	= GENMASK(21, 20),

	[DYNAMIC_MAC_TABLE_TIMESTAMP]	= GENMASK(23, 22),
@@ -420,7 +420,7 @@ static u8 ksz8863_shifts[] = { 
	[VLAN_TABLE_MEMBERSHIP_S]	= 16,

	[STATIC_MAC_FWD_PORTS]		= 16,

	[STATIC_MAC_FID]		= 22,

	[DYNAMIC_MAC_ENTRIES_H]		= 3,

	[DYNAMIC_MAC_ENTRIES_H]		= 8,

	[DYNAMIC_MAC_ENTRIES]		= 24,

	[DYNAMIC_MAC_FID]		= 16,

	[DYNAMIC_MAC_TIMESTAMP]		= 24,