Commit 5dd00ebd authored by Chao Yu's avatar Chao Yu Committed by Jaegeuk Kim
Browse files

f2fs: fix to map blocks correctly for direct write 



f2fs_map_blocks() supports to map continuous holes or preallocated
address, we should avoid setting F2FS_MAP_MAPPED for these cases
only, otherwise, it may fail f2fs_iomap_begin(), and make direct
write fallbacking to use buffered IO and flush, result in performance
regression.

Fixes: 9f0f6bf4 ("f2fs: support to map continuous holes or preallocated address")
Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Closes: https://lore.kernel.org/oe-lkp/202409122103.e45aa13b-oliver.sang@intel.com


Cc: Cyril Hrubis <chrubis@suse.cz>
Signed-off-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 7b0033db

fs/f2fs/data.c

+2 −1
Original line number Diff line number Diff line
@@ -1676,7 +1676,8 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, int flag) 
		/* reserved delalloc block should be mapped for fiemap. */

		if (blkaddr == NEW_ADDR)

			map->m_flags |= F2FS_MAP_DELALLOC;

		if (flag != F2FS_GET_BLOCK_DIO || !is_hole)

		/* DIO READ and hole case, should not map the blocks. */

		if (!(flag == F2FS_GET_BLOCK_DIO && is_hole && !map->m_may_create))

			map->m_flags |= F2FS_MAP_MAPPED;



		map->m_pblk = blkaddr;