Commit 5ddc1e27 authored by Cai Huoqing's avatar Cai Huoqing Committed by Sam Ravnborg
Browse files

drm/panel: fy07024di26a30d: Make use of the helper function dev_err_probe() 



When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: default avatarCai Huoqing <caihuoqing@baidu.com>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210916104232.11164-1-caihuoqing@baidu.com
parent 6b1a69bc

drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c

+9 −12
Original line number Diff line number Diff line
@@ -200,22 +200,19 @@ static int feiyang_dsi_probe(struct mipi_dsi_device *dsi) 
		       DRM_MODE_CONNECTOR_DSI);



	ctx->dvdd = devm_regulator_get(&dsi->dev, "dvdd");

	if (IS_ERR(ctx->dvdd)) {

		dev_err(&dsi->dev, "Couldn't get dvdd regulator\n");

		return PTR_ERR(ctx->dvdd);

	}

	if (IS_ERR(ctx->dvdd))

		return dev_err_probe(&dsi->dev, PTR_ERR(ctx->dvdd),

				     "Couldn't get dvdd regulator\n");



	ctx->avdd = devm_regulator_get(&dsi->dev, "avdd");

	if (IS_ERR(ctx->avdd)) {

		dev_err(&dsi->dev, "Couldn't get avdd regulator\n");

		return PTR_ERR(ctx->avdd);

	}

	if (IS_ERR(ctx->avdd))

		return dev_err_probe(&dsi->dev, PTR_ERR(ctx->avdd),

				     "Couldn't get avdd regulator\n");



	ctx->reset = devm_gpiod_get(&dsi->dev, "reset", GPIOD_OUT_LOW);

	if (IS_ERR(ctx->reset)) {

		dev_err(&dsi->dev, "Couldn't get our reset GPIO\n");

		return PTR_ERR(ctx->reset);

	}

	if (IS_ERR(ctx->reset))

		return dev_err_probe(&dsi->dev, PTR_ERR(ctx->reset),

				     "Couldn't get our reset GPIO\n");



	ret = drm_panel_of_backlight(&ctx->panel);

	if (ret)