Commit 5dea0c3f authored by Chris Morgan's avatar Chris Morgan Committed by Neil Armstrong
Browse files

drm/panel-elida-kd35t133: Drop shutdown logic 



The driver shutdown is duplicate as it calls drm_unprepare and
drm_disable which are called anyway when associated drivers are
shutdown/removed.

Signed-off-by: default avatarChris Morgan <macromorgan@hotmail.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20231117194405.1386265-5-macroalpha82@gmail.com


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231117194405.1386265-5-macroalpha82@gmail.com
parent 3fc828b8

drivers/gpu/drm/panel/panel-elida-kd35t133.c

+0 −17
Original line number Diff line number Diff line
@@ -296,27 +296,11 @@ static int kd35t133_probe(struct mipi_dsi_device *dsi) 
	return 0;

}



static void kd35t133_shutdown(struct mipi_dsi_device *dsi)

{

	struct kd35t133 *ctx = mipi_dsi_get_drvdata(dsi);

	int ret;



	ret = drm_panel_unprepare(&ctx->panel);

	if (ret < 0)

		dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret);



	ret = drm_panel_disable(&ctx->panel);

	if (ret < 0)

		dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret);

}



static void kd35t133_remove(struct mipi_dsi_device *dsi)

{

	struct kd35t133 *ctx = mipi_dsi_get_drvdata(dsi);

	int ret;



	kd35t133_shutdown(dsi);



	ret = mipi_dsi_detach(dsi);

	if (ret < 0)

		dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret);
@@ -337,7 +321,6 @@ static struct mipi_dsi_driver kd35t133_driver = { 
	},

	.probe	= kd35t133_probe,

	.remove = kd35t133_remove,

	.shutdown = kd35t133_shutdown,

};

module_mipi_dsi_driver(kd35t133_driver);