Commit 5e06e089 authored by I Hsin Cheng's avatar I Hsin Cheng Committed by Andrew Morton
Browse files

list: test: increase coverage of list_test_list_replace*() 

Increase the test coverage of list_test_list_replace*() by adding the
checks to compare the pointer of "a_new.next" and "a_new.prev" to make
sure a perfect circular doubly linked list is formed after the
replacement.

Link: https://lkml.kernel.org/r/20240910040818.65723-1-richard120310@gmail.com


Signed-off-by: default avatarI Hsin Cheng <richard120310@gmail.com>
Cc: David Gow <davidgow@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent e620799c

lib/list-test.c

+4 −0
Original line number Diff line number Diff line
@@ -102,6 +102,8 @@ static void list_test_list_replace(struct kunit *test) 
	/* now: [list] -> a_new -> b */

	KUNIT_EXPECT_PTR_EQ(test, list.next, &a_new);

	KUNIT_EXPECT_PTR_EQ(test, b.prev, &a_new);

	KUNIT_EXPECT_PTR_EQ(test, a_new.next, &b);

	KUNIT_EXPECT_PTR_EQ(test, a_new.prev, &list);

}



static void list_test_list_replace_init(struct kunit *test)
@@ -118,6 +120,8 @@ static void list_test_list_replace_init(struct kunit *test) 
	/* now: [list] -> a_new -> b */

	KUNIT_EXPECT_PTR_EQ(test, list.next, &a_new);

	KUNIT_EXPECT_PTR_EQ(test, b.prev, &a_new);

	KUNIT_EXPECT_PTR_EQ(test, a_new.next, &b);

	KUNIT_EXPECT_PTR_EQ(test, a_new.prev, &list);



	/* check a_old is empty (initialized) */

	KUNIT_EXPECT_TRUE(test, list_empty_careful(&a_old));