Commit 5e23c981 authored by Marek Vasut's avatar Marek Vasut Committed by Sam Ravnborg
Browse files

drm: mxsfb: Clear FIFO_CLEAR bit 



Make sure the FIFO_CLEAR bit is latched in when configuring the
controller, so that the FIFO is really cleared. And then clear
the FIFO_CLEAR bit, since it is not self-clearing.

Fixes: 45d59d70 ("drm: Add new driver for MXSFB controller")
Signed-off-by: default avatarMarek Vasut <marex@denx.de>
Cc: Daniel Abrecht <public@danielabrecht.ch>
Cc: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Stefan Agner <stefan@agner.ch>
Reviewed-by: default avatarJagan Teki <jagan@amarulasolutions.com>
Tested-by: Jagan Teki <jagan@amarulasolutions.com> # i.Core MX8MM
Acked-by: default avatarLucas Stach <l.stach@pengutronix.de>
Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210620224946.189524-1-marex@denx.de
parent b776b0f0

drivers/gpu/drm/mxsfb/mxsfb_kms.c

+3 −0
Original line number Diff line number Diff line
@@ -241,6 +241,9 @@ static void mxsfb_crtc_mode_set_nofb(struct mxsfb_drm_private *mxsfb, 


	/* Clear the FIFOs */

	writel(CTRL1_FIFO_CLEAR, mxsfb->base + LCDC_CTRL1 + REG_SET);

	readl(mxsfb->base + LCDC_CTRL1);

	writel(CTRL1_FIFO_CLEAR, mxsfb->base + LCDC_CTRL1 + REG_CLR);

	readl(mxsfb->base + LCDC_CTRL1);



	if (mxsfb->devdata->has_overlay)

		writel(0, mxsfb->base + LCDC_AS_CTRL);