Commit 5e40fb2d authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

x86/cpu/topology: Simplify cpu_mark_primary_thread() 



No point in creating a mask via fls(). smp_num_siblings is guaranteed to be
a power of 2. So just using (smp_num_siblings - 1) has the same effect.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Tested-by: default avatarMichael Kelley <mhklinux@outlook.com>
Tested-by: default avatarSohil Mehta <sohil.mehta@intel.com>
Link: https://lore.kernel.org/r/20240213210252.791176581@linutronix.de
parent 882e0cff

arch/x86/kernel/cpu/topology.c

+1 −4
Original line number Diff line number Diff line
@@ -76,10 +76,7 @@ bool arch_match_cpu_phys_id(int cpu, u64 phys_id) 
#ifdef CONFIG_SMP

static void cpu_mark_primary_thread(unsigned int cpu, unsigned int apicid)

{

	/* Isolate the SMT bit(s) in the APICID and check for 0 */

	u32 mask = (1U << (fls(smp_num_siblings) - 1)) - 1;



	if (smp_num_siblings == 1 || !(apicid & mask))

	if (!(apicid & (smp_num_siblings - 1)))

		cpumask_set_cpu(cpu, &__cpu_primary_thread_mask);

}

#else