Commit 5e52f71f authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Keith Busch
Browse files

nvme: use helpers to access io_uring cmd space 



Command implementations shouldn't be directly looking into io_uring_cmd
to carve free space. Use an io_uring helper, which will also do build
time size sanitisation.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Reviewed-by: default avatarKanchan Joshi <joshi.k@samsung.com>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: default avatarAnuj Gupta <anuj20.g@samsung.com>
Reviewed-by: default avatarJens Axboe <axboe@kernel.dk>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent fdad1a20

drivers/nvme/host/ioctl.c

+1 −3
Original line number Diff line number Diff line
@@ -402,7 +402,7 @@ struct nvme_uring_cmd_pdu { 
static inline struct nvme_uring_cmd_pdu *nvme_uring_cmd_pdu(

		struct io_uring_cmd *ioucmd)

{

	return (struct nvme_uring_cmd_pdu *)&ioucmd->pdu;

	return io_uring_cmd_to_pdu(ioucmd, struct nvme_uring_cmd_pdu);

}



static void nvme_uring_task_cb(struct io_uring_cmd *ioucmd,
@@ -632,8 +632,6 @@ static int nvme_ns_uring_cmd(struct nvme_ns *ns, struct io_uring_cmd *ioucmd, 
	struct nvme_ctrl *ctrl = ns->ctrl;

	int ret;



	BUILD_BUG_ON(sizeof(struct nvme_uring_cmd_pdu) > sizeof(ioucmd->pdu));



	ret = nvme_uring_cmd_checks(issue_flags);

	if (ret)

		return ret;