Commit 5ec39944 authored by Chuck Lever's avatar Chuck Lever
Browse files

NFSD: Rewrite synopsis of nfsd_percpu_counters_init() 



In function ‘export_stats_init’,
    inlined from ‘svc_export_alloc’ at fs/nfsd/export.c:866:6:
fs/nfsd/export.c:337:16: warning: ‘nfsd_percpu_counters_init’ accessing 40 bytes in a region of size 0 [-Wstringop-overflow=]
  337 |         return nfsd_percpu_counters_init(&stats->counter, EXP_STATS_COUNTERS_NUM);
      |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
fs/nfsd/export.c:337:16: note: referencing argument 1 of type ‘struct percpu_counter[0]’
fs/nfsd/stats.h: In function ‘svc_export_alloc’:
fs/nfsd/stats.h:40:5: note: in a call to function ‘nfsd_percpu_counters_init’
   40 | int nfsd_percpu_counters_init(struct percpu_counter counters[], int num);
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~

Cc: Amir Goldstein <amir73il@gmail.com>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarChuck Lever <chuck.lever@oracle.com>
parent afb8aae5

fs/nfsd/stats.c

+1 −1
Original line number Diff line number Diff line
@@ -76,7 +76,7 @@ static int nfsd_show(struct seq_file *seq, void *v) 


DEFINE_PROC_SHOW_ATTRIBUTE(nfsd);



int nfsd_percpu_counters_init(struct percpu_counter counters[], int num)

int nfsd_percpu_counters_init(struct percpu_counter *counters, int num)

{

	int i, err = 0;

fs/nfsd/stats.h

+3 −3
Original line number Diff line number Diff line
@@ -37,9 +37,9 @@ extern struct nfsd_stats nfsdstats; 


extern struct svc_stat		nfsd_svcstats;



int nfsd_percpu_counters_init(struct percpu_counter counters[], int num);

void nfsd_percpu_counters_reset(struct percpu_counter counters[], int num);

void nfsd_percpu_counters_destroy(struct percpu_counter counters[], int num);

int nfsd_percpu_counters_init(struct percpu_counter *counters, int num);

void nfsd_percpu_counters_reset(struct percpu_counter *counters, int num);

void nfsd_percpu_counters_destroy(struct percpu_counter *counters, int num);

int nfsd_stat_init(void);

void nfsd_stat_shutdown(void);