Commit 5effda1c authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Madhavan Srinivasan
Browse files

powerpc: 44x/gpio: use new line value setter callbacks 



struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: default avatarMadhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250502-gpiochip-set-rv-powerpc-v2-3-488e43e325bf@linaro.org
parent 077f8733

arch/powerpc/platforms/44x/gpio.c

+4 −3
Original line number Diff line number Diff line
@@ -75,8 +75,7 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) 
		clrbits32(&regs->or, GPIO_MASK(gpio));

}



static void

ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)

static int ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)

{

	struct ppc4xx_gpio_chip *chip = gpiochip_get_data(gc);

	unsigned long flags;
@@ -88,6 +87,8 @@ ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) 
	spin_unlock_irqrestore(&chip->lock, flags);



	pr_debug("%s: gpio: %d val: %d\n", __func__, gpio, val);



	return 0;

}



static int ppc4xx_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio)
@@ -179,7 +180,7 @@ static int __init ppc4xx_add_gpiochips(void) 
		gc->direction_input = ppc4xx_gpio_dir_in;

		gc->direction_output = ppc4xx_gpio_dir_out;

		gc->get = ppc4xx_gpio_get;

		gc->set = ppc4xx_gpio_set;

		gc->set_rv = ppc4xx_gpio_set;



		ret = of_mm_gpiochip_add_data(np, mm_gc, ppc4xx_gc);

		if (ret)