Commit 5f011b44 authored by Dmitry Baryshkov's avatar Dmitry Baryshkov
Browse files

drm/sti: hda: pass const struct drm_display_mode* to hda_get_mode_idx() 



Make hda_get_mode_idx() take a const struct drm_display_mode pointer
instead of just raw struct drm_display_mode. This is a preparation to
converting the mode_valid() callback of drm_connector to take a const
struct drm_display_mode argument.

Acked-by: default avatarRaphael Gallais-Pou <rgallaispou@gmail.com>
Reviewed-by: default avatarLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: default avatarMaxime Ripard <mripard@kernel.org>
Reviewed-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarHarry Wentland <harry.wentland@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241214-drm-connector-mode-valid-const-v2-3-4f9498a4c822@linaro.org


Signed-off-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
parent b255ce43

drivers/gpu/drm/sti/sti_hda.c

+5 −5
Original line number Diff line number Diff line
@@ -280,12 +280,12 @@ static void hda_write(struct sti_hda *hda, u32 val, int offset) 
 *

 * Return true if mode is found

 */

static bool hda_get_mode_idx(struct drm_display_mode mode, int *idx)

static bool hda_get_mode_idx(const struct drm_display_mode *mode, int *idx)

{

	unsigned int i;



	for (i = 0; i < ARRAY_SIZE(hda_supported_modes); i++)

		if (drm_mode_equal(&hda_supported_modes[i].mode, &mode)) {

		if (drm_mode_equal(&hda_supported_modes[i].mode, mode)) {

			*idx = i;

			return true;

		}
@@ -443,7 +443,7 @@ static void sti_hda_pre_enable(struct drm_bridge *bridge) 
	if (clk_prepare_enable(hda->clk_hddac))

		DRM_ERROR("Failed to prepare/enable hda_hddac clk\n");



	if (!hda_get_mode_idx(hda->mode, &mode_idx)) {

	if (!hda_get_mode_idx(&hda->mode, &mode_idx)) {

		DRM_ERROR("Undefined mode\n");

		return;

	}
@@ -526,7 +526,7 @@ static void sti_hda_set_mode(struct drm_bridge *bridge, 


	drm_mode_copy(&hda->mode, mode);



	if (!hda_get_mode_idx(hda->mode, &mode_idx)) {

	if (!hda_get_mode_idx(&hda->mode, &mode_idx)) {

		DRM_ERROR("Undefined mode\n");

		return;

	}
@@ -614,7 +614,7 @@ sti_hda_connector_mode_valid(struct drm_connector *connector, 
		= to_sti_hda_connector(connector);

	struct sti_hda *hda = hda_connector->hda;



	if (!hda_get_mode_idx(*mode, &idx)) {

	if (!hda_get_mode_idx(mode, &idx)) {

		return MODE_BAD;

	} else {

		result = clk_round_rate(hda->clk_pix, target);