Commit 5f1c8108 authored by Nihar Chaithanya's avatar Nihar Chaithanya Committed by Andrew Morton
Browse files

mm:kasan: fix sparse warnings: Should it be static? 

Yes, when making the global variables kasan_ptr_result and
kasan_int_result as static volatile, the warnings are removed and the
variable and assignments are retained, but when just static is used I
understand that it might be optimized.

Add a fix making the global varaibles - static volatile, removing the
warnings:
mm/kasan/kasan_test.c:36:6: warning: symbol 'kasan_ptr_result' was not declared. Should it be static?
mm/kasan/kasan_test.c:37:5: warning: symbol 'kasan_int_result' was not declared. Should it be static?

Link: https://lkml.kernel.org/r/20241011114537.35664-1-niharchaithanya@gmail.com


Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312261010.o0lRiI9b-lkp@intel.com/


Signed-off-by: default avatarNihar Chaithanya <niharchaithanya@gmail.com>
Reviewed-by: default avatarDmitry Vyukov <dvyukov@google.com>
Reviewed-by: default avatarAndrey Konovalov <andreyknvl@gmail.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 21641bd9

mm/kasan/kasan_test_c.c

+2 −2
Original line number Diff line number Diff line
@@ -47,8 +47,8 @@ static struct { 
 * Some tests use these global variables to store return values from function

 * calls that could otherwise be eliminated by the compiler as dead code.

 */

void *kasan_ptr_result;

int kasan_int_result;

static volatile void *kasan_ptr_result;

static volatile int kasan_int_result;



/* Probe for console output: obtains test_status lines of interest. */

static void probe_console(void *ignore, const char *buf, size_t len)