Commit 5f48d4d9 authored by Baokun Li's avatar Baokun Li Committed by Theodore Ts'o
Browse files

ext4: save unnecessary indentation in ext4_ext_create_new_leaf() 



Save an indentation level in ext4_ext_create_new_leaf() by removing
unnecessary 'else'. Besides, the variable 'ee_block' is declared to
avoid line breaks. No functional changes.

Suggested-by: default avatarJan Kara <jack@suse.cz>
Signed-off-by: default avatarBaokun Li <libaokun1@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20240822023545.1994557-26-libaokun@huaweicloud.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 2352e3e4

fs/ext4/extents.c

+21 −23
Original line number Diff line number Diff line
@@ -1403,6 +1403,7 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode, 
{

	struct ext4_ext_path *curp;

	int depth, i, err = 0;

	ext4_lblk_t ee_block = le32_to_cpu(newext->ee_block);



repeat:

	i = depth = ext_depth(inode);
@@ -1424,20 +1425,17 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode, 
			goto errout;



		/* refill path */

		path = ext4_find_extent(inode,

				    (ext4_lblk_t)le32_to_cpu(newext->ee_block),

				    path, gb_flags);

		path = ext4_find_extent(inode, ee_block, path, gb_flags);

		return path;

	} else {

	}



	/* tree is full, time to grow in depth */

	err = ext4_ext_grow_indepth(handle, inode, mb_flags);

	if (err)

		goto errout;



	/* refill path */

		path = ext4_find_extent(inode,

				   (ext4_lblk_t)le32_to_cpu(newext->ee_block),

				    path, gb_flags);

	path = ext4_find_extent(inode, ee_block, path, gb_flags);

	if (IS_ERR(path))

		return path;
@@ -1450,7 +1448,7 @@ ext4_ext_create_new_leaf(handle_t *handle, struct inode *inode, 
		/* now we need to split */

		goto repeat;

	}

	}



	return path;



errout: