Unverified Commit 5fb38782 authored by I Hsin Cheng's avatar I Hsin Cheng Committed by Mark Brown
Browse files

ASoC: intel/sdw_utils: Assign initial value in asoc_sdw_rt_amp_spk_rtd_init() 

Initialize "ret" with "-EINVAL" to handle cases where "strstr()" for
"codec_dai->component->name_prefix" doesn't find "-1" nor "-2". In that
case "name_prefix" is invalid because for current implementation it's
expected to have either "-1" or "-2" in it. (Maybe "-3", "-4" and so on
in the future.)

Link: https://scan5.scan.coverity.com/#/project-view/36179/10063?selectedIssue=1627120


Signed-off-by: default avatarI Hsin Cheng <richard120310@gmail.com>
Link: https://patch.msgid.link/20250505185423.680608-1-richard120310@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 04cb269c

sound/soc/sdw_utils/soc_sdw_rt_amp.c

+1 −1
Original line number Diff line number Diff line
@@ -190,7 +190,7 @@ int asoc_sdw_rt_amp_spk_rtd_init(struct snd_soc_pcm_runtime *rtd, struct snd_soc 
	const struct snd_soc_dapm_route *rt_amp_map;

	char codec_name[CODEC_NAME_SIZE];

	struct snd_soc_dai *codec_dai;

	int ret;

	int ret = -EINVAL;

	int i;



	rt_amp_map = get_codec_name_and_route(dai, codec_name);