Commit 5ff74f5f authored by Eric Biggers's avatar Eric Biggers
Browse files

lib/crc: Drop inline from all *_mod_init_arch() functions 

Drop 'inline' from all the *_mod_init_arch() functions so that the
compiler will warn about any bugs where they are unused due to not being
wired up properly.  (There are no such bugs currently, so this just
establishes a more robust convention for the future.  Of course, these
functions also tend to get inlined anyway, regardless of the keyword.)

Link: https://lore.kernel.org/r/20250816020240.431545-1-ebiggers@kernel.org


Signed-off-by: default avatarEric Biggers <ebiggers@kernel.org>
parent c2a0c515

lib/crc/arm/crc-t10dif.h

+1 −1
Original line number Diff line number Diff line
@@ -43,7 +43,7 @@ static inline u16 crc_t10dif_arch(u16 crc, const u8 *data, size_t length) 
}



#define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch

static inline void crc_t10dif_mod_init_arch(void)

static void crc_t10dif_mod_init_arch(void)

{

	if (elf_hwcap & HWCAP_NEON) {

		static_branch_enable(&have_neon);

lib/crc/arm/crc32.h

+1 −1
Original line number Diff line number Diff line
@@ -83,7 +83,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len) 
#define crc32_be_arch crc32_be_base /* not implemented on this arch */



#define crc32_mod_init_arch crc32_mod_init_arch

static inline void crc32_mod_init_arch(void)

static void crc32_mod_init_arch(void)

{

	if (elf_hwcap2 & HWCAP2_CRC32)

		static_branch_enable(&have_crc32);

lib/crc/arm64/crc-t10dif.h

+1 −1
Original line number Diff line number Diff line
@@ -45,7 +45,7 @@ static inline u16 crc_t10dif_arch(u16 crc, const u8 *data, size_t length) 
}



#define crc_t10dif_mod_init_arch crc_t10dif_mod_init_arch

static inline void crc_t10dif_mod_init_arch(void)

static void crc_t10dif_mod_init_arch(void)

{

	if (cpu_have_named_feature(ASIMD)) {

		static_branch_enable(&have_asimd);

lib/crc/loongarch/crc32.h

+1 −1
Original line number Diff line number Diff line
@@ -101,7 +101,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len) 
#define crc32_be_arch crc32_be_base /* not implemented on this arch */



#define crc32_mod_init_arch crc32_mod_init_arch

static inline void crc32_mod_init_arch(void)

static void crc32_mod_init_arch(void)

{

	if (cpu_has_crc32)

		static_branch_enable(&have_crc32);

lib/crc/mips/crc32.h

+1 −1
Original line number Diff line number Diff line
@@ -148,7 +148,7 @@ static inline u32 crc32c_arch(u32 crc, const u8 *p, size_t len) 
#define crc32_be_arch crc32_be_base /* not implemented on this arch */



#define crc32_mod_init_arch crc32_mod_init_arch

static inline void crc32_mod_init_arch(void)

static void crc32_mod_init_arch(void)

{

	if (cpu_have_feature(cpu_feature(MIPS_CRC32)))

		static_branch_enable(&have_crc32);