Commit 609e60a3 authored by Guixin Liu's avatar Guixin Liu Committed by Keith Busch
Browse files

nvmet: report ns's vwc not present 



Currently, we report that controller has vwc even though the ns may
not have vwc. Report ns's vwc not present when not buffered_io or
backdev doesn't have vwc.

Signed-off-by: default avatarGuixin Liu <kanie@linux.alibaba.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 8a825d22

drivers/nvme/target/admin-cmd.c

+7 −0
Original line number Diff line number Diff line
@@ -934,6 +934,13 @@ static void nvmet_execute_id_cs_indep(struct nvmet_req *req) 
		id->nsattr |= NVME_NS_ATTR_RO;

	if (req->ns->bdev && !bdev_nonrot(req->ns->bdev))

		id->nsfeat |= NVME_NS_ROTATIONAL;

	/*

	 * We need flush command to flush the file's metadata,

	 * so report supporting vwc if backend is file, even

	 * though buffered_io is disable.

	 */

	if (req->ns->bdev && !bdev_write_cache(req->ns->bdev))

		id->nsfeat |= NVME_NS_VWC_NOT_PRESENT;



	status = nvmet_copy_to_sgl(req, 0, id, sizeof(*id));

	kfree(id);