Commit 60a06efc authored by Abhishek Tamboli's avatar Abhishek Tamboli Committed by Alexandre Belloni
Browse files

rtc: m48t59: Remove division condition with direct comparison 



Replace 'year / 100' with a direct comparison 'year >= 100'
in m48t59_rtc_set_time() function. Improve the code clarity
and eliminate division overhead.

Fix the following smatch warning:
drivers/rtc/rtc-m48t59.c:135 m48t59_rtc_set_time() warn:
replace divide condition 'year / 100' with 'year >= 100'

Signed-off-by: default avatarAbhishek Tamboli <abhishektamboli9@gmail.com>
Link: https://lore.kernel.org/r/20240809155631.548044-1-abhishektamboli9@gmail.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 73580e2e

drivers/rtc/rtc-m48t59.c

+1 −1
Original line number Diff line number Diff line
@@ -132,7 +132,7 @@ static int m48t59_rtc_set_time(struct device *dev, struct rtc_time *tm) 
	M48T59_WRITE((bin2bcd(tm->tm_mon + 1) & 0x1F), M48T59_MONTH);

	M48T59_WRITE(bin2bcd(year % 100), M48T59_YEAR);



	if (pdata->type == M48T59RTC_TYPE_M48T59 && (year / 100))

	if (pdata->type == M48T59RTC_TYPE_M48T59 && (year >= 100))

		val = (M48T59_WDAY_CEB | M48T59_WDAY_CB);

	val |= (bin2bcd(tm->tm_wday) & 0x07);

	M48T59_WRITE(val, M48T59_WDAY);