Commit 60a1f6a8 authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ufs: core: Only call ufshcd_add_command_trace() for SCSI commands 



Instead of checking inside ufshcd_add_command_trace() whether 'cmd'
points at a SCSI command, let the caller perform that check. This patch
prepares for removing the lrbp->cmd pointer.

Reviewed-by: default avatarAvri Altman <avri.altman@sandisk.com>
Reviewed-by: default avatarPeter Wang <peter.wang@mediatek.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://patch.msgid.link/20251031204029.2883185-11-bvanassche@acm.org


Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 9f8e0923

drivers/ufs/core/ufshcd.c

+3 −5
Original line number Diff line number Diff line
@@ -486,9 +486,6 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba, unsigned int tag, 
	struct request *rq = scsi_cmd_to_rq(cmd);

	int transfer_len = -1;



	if (!cmd)

		return;



	/* trace UPIU also */

	ufshcd_add_cmd_upiu_trace(hba, lrbp, str_t);

	if (!trace_ufshcd_command_enabled())
@@ -2369,9 +2366,10 @@ void ufshcd_send_command(struct ufs_hba *hba, unsigned int task_tag, 
		lrbp->compl_time_stamp = ktime_set(0, 0);

		lrbp->compl_time_stamp_local_clock = 0;

	}

	if (lrbp->cmd) {

		ufshcd_add_command_trace(hba, task_tag, UFS_CMD_SEND);

	if (lrbp->cmd)

		ufshcd_clk_scaling_start_busy(hba);

	}

	if (unlikely(ufshcd_should_inform_monitor(hba, lrbp)))

		ufshcd_start_monitor(hba, lrbp);