Commit 616576df authored by Dan Carpenter's avatar Dan Carpenter Committed by Thomas Hellström
Browse files

drm/xe/selftests: Fix an error pointer dereference bug 



Check if "bo" is an error pointer before calling xe_bo_lock() on it.

Fixes: d6abc18d ("drm/xe/xe2: Modify xe_bo_test for system memory")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarMatthew Brost <matthew.brost@intel.com>
Reviewed-by: default avatarMatthew Brost <matthew.brost@intel.com>
(cherry picked from commit 88ec2352)
Signed-off-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
parent ffd915e4

drivers/gpu/drm/xe/tests/xe_bo.c

+2 −3
Original line number Diff line number Diff line
@@ -125,14 +125,13 @@ static void ccs_test_run_tile(struct xe_device *xe, struct xe_tile *tile, 


	bo = xe_bo_create_user(xe, NULL, NULL, SZ_1M, DRM_XE_GEM_CPU_CACHING_WC,

			       ttm_bo_type_device, bo_flags);



	xe_bo_lock(bo, false);



	if (IS_ERR(bo)) {

		KUNIT_FAIL(test, "Failed to create bo.\n");

		return;

	}



	xe_bo_lock(bo, false);



	kunit_info(test, "Verifying that CCS data is cleared on creation.\n");

	ret = ccs_test_migrate(tile, bo, false, 0ULL, 0xdeadbeefdeadbeefULL,

			       test);