Commit 61ff60aa authored by Ian Rogers's avatar Ian Rogers Committed by Arnaldo Carvalho de Melo
Browse files

perf util: Add shellcheck to generate-cmdlist.sh 



Add shellcheck to generate-cmdlist.sh to avoid basic shell script
mistakes.

Reviewed-by: default avatarJames Clark <james.clark@arm.com>
Signed-off-by: default avatarIan Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Oliver Upton <oliver.upton@linux.dev>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Link: https://lore.kernel.org/r/20240409023216.2342032-4-irogers@google.com


Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent ec440763

tools/perf/util/Build

+14 −0
Original line number Diff line number Diff line
@@ -389,3 +389,17 @@ $(OUTPUT)util/vsprintf.o: ../lib/vsprintf.c FORCE 
$(OUTPUT)util/list_sort.o: ../lib/list_sort.c FORCE

	$(call rule_mkdir)

	$(call if_changed_dep,cc_o_c)



ifdef SHELLCHECK

  SHELL_TESTS := generate-cmdlist.sh

  TEST_LOGS := $(SHELL_TESTS:%=%.shellcheck_log)

else

  SHELL_TESTS :=

  TEST_LOGS :=

endif



$(OUTPUT)%.shellcheck_log: %

	$(call rule_mkdir)

	$(Q)$(call echo-cmd,test)shellcheck -a -S warning "$<" > $@ || (cat $@ && rm $@ && false)



perf-y += $(TEST_LOGS)