Commit 62c5a01a authored by Ma Ke's avatar Ma Ke Committed by Greg Kroah-Hartman
Browse files

pps: add an error check in parport_attach 



In parport_attach, the return value of ida_alloc is unchecked, witch leads
to the use of an invalid index value.

To address this issue, index should be checked. When the index value is
abnormal, the device should be freed.

Found by code review, compile tested only.

Cc: stable@vger.kernel.org
Fixes: fb56d97d ("pps: client: use new parport device model")
Signed-off-by: default avatarMa Ke <make24@iscas.ac.cn>
Acked-by: default avatarRodolfo Giometti <giometti@enneenne.com>
Link: https://lore.kernel.org/r/20240828131814.3034338-1-make24@iscas.ac.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 43027957

drivers/pps/clients/pps_parport.c

+6 −2
Original line number Diff line number Diff line
@@ -149,6 +149,9 @@ static void parport_attach(struct parport *port) 
	}



	index = ida_alloc(&pps_client_index, GFP_KERNEL);

	if (index < 0)

		goto err_free_device;



	memset(&pps_client_cb, 0, sizeof(pps_client_cb));

	pps_client_cb.private = device;

	pps_client_cb.irq_func = parport_irq;
@@ -159,7 +162,7 @@ static void parport_attach(struct parport *port) 
						    index);

	if (!device->pardev) {

		pr_err("couldn't register with %s\n", port->name);

		goto err_free;

		goto err_free_ida;

	}



	if (parport_claim_or_block(device->pardev) < 0) {
@@ -187,8 +190,9 @@ static void parport_attach(struct parport *port) 
	parport_release(device->pardev);

err_unregister_dev:

	parport_unregister_device(device->pardev);

err_free:

err_free_ida:

	ida_free(&pps_client_index, index);

err_free_device:

	kfree(device);

}