Commit 6320b919 authored by Douglas Anderson's avatar Douglas Anderson Committed by Neil Armstrong
Browse files

drm/panel: boe-tv101wum-nl6: Check for errors on the NOP in prepare() 



The mipi_dsi_dcs_nop() function returns an error but we weren't
checking it in boe_panel_prepare(). Add a check. This is highly
unlikely to matter in practice. If the NOP failed then likely later
MIPI commands would fail too.

Found by code inspection.

Fixes: 812562b8 ("drm/panel: boe-tv101wum-nl6: Fine tune the panel power sequence")
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240517143643.3.Ibffbaa5b4999ac0e55f43bf353144433b099d727@changeid
parent 587c48f6

drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c

+5 −1
Original line number Diff line number Diff line
@@ -1456,7 +1456,11 @@ static int boe_panel_prepare(struct drm_panel *panel) 
	usleep_range(10000, 11000);



	if (boe->desc->lp11_before_reset) {

		mipi_dsi_dcs_nop(boe->dsi);

		ret = mipi_dsi_dcs_nop(boe->dsi);

		if (ret < 0) {

			dev_err(&boe->dsi->dev, "Failed to send NOP: %d\n", ret);

			goto poweroff;

		}

		usleep_range(1000, 2000);

	}

	gpiod_set_value(boe->enable_gpio, 1);