Commit 6371b4bc authored by Colin Ian King's avatar Colin Ian King Committed by Steven Rostedt (Google)
Browse files

tracing: Remove redundant check on field->field in histograms 

The check on field->field being true is handled as the first check
on the cascaded if statement, so the later checks on field->field
are redundant because this clause has already been handled. Since
this later check is redundant, just remove it.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://lore.kernel.org/20241107120530.18728-1-colin.i.king@gmail.com


Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent 24507ce8

kernel/trace/trace_events_hist.c

+1 −4
Original line number Diff line number Diff line
@@ -1354,9 +1354,6 @@ static const char *hist_field_name(struct hist_field *field, 
	} else if (field->flags & HIST_FIELD_FL_TIMESTAMP)

		field_name = "common_timestamp";

	else if (field->flags & HIST_FIELD_FL_STACKTRACE) {

		if (field->field)

			field_name = field->field->name;

		else

		field_name = "common_stacktrace";

	} else if (field->flags & HIST_FIELD_FL_HITCOUNT)

		field_name = "hitcount";