Commit 63bcf901 authored by Hannes Reinecke's avatar Hannes Reinecke Committed by Keith Busch
Browse files

nvme-multipath: system fails to create generic nvme device 



NVME_NSHEAD_DISK_LIVE is a flag for struct nvme_ns_head, not nvme_ns.
The current code has a typo causing NVME_NSHEAD_DISK_LIVE never to
be cleared once device_add_disk_fails, causing the system never to
create the 'generic' character device. Even several rescan attempts
will change the situation and the system has to be rebooted to fix
the issue.

Fixes: 11384580 ("nvme-multipath: add error handling support for add_disk()")
Signed-off-by: default avatarHannes Reinecke <hare@kernel.org>
Reviewed-by: default avatarSagi Grimberg <sagi@grimberg.me>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent 65f666c6

drivers/nvme/host/multipath.c

+1 −1
Original line number Diff line number Diff line
@@ -648,7 +648,7 @@ static void nvme_mpath_set_live(struct nvme_ns *ns) 
		rc = device_add_disk(&head->subsys->dev, head->disk,

				     nvme_ns_attr_groups);

		if (rc) {

			clear_bit(NVME_NSHEAD_DISK_LIVE, &ns->flags);

			clear_bit(NVME_NSHEAD_DISK_LIVE, &head->flags);

			return;

		}

		nvme_add_ns_head_cdev(head);