Unverified Commit 63fe2986 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Mark Brown
Browse files

ASoC: codecs: wcd9375: Fix double free of regulator supplies 



Driver gets regulator supplies in probe path with
devm_regulator_bulk_get(), so should not call regulator_bulk_free() in
error and remove paths to avoid double free.

Fixes: 216d0413 ("ASoC: codecs: wcd937x: Remove separate handling for vdd-buck supply")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20250526-b4-b4-asoc-wcd9395-vdd-px-fixes-v1-3-0b8a2993b7d3@linaro.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent dc59189d

sound/soc/codecs/wcd937x.c

+1 −5
Original line number Diff line number Diff line
@@ -2944,10 +2944,8 @@ static int wcd937x_probe(struct platform_device *pdev) 
		return dev_err_probe(dev, ret, "Failed to get supplies\n");



	ret = regulator_bulk_enable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies);

	if (ret) {

		regulator_bulk_free(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies);

	if (ret)

		return dev_err_probe(dev, ret, "Failed to enable supplies\n");

	}



	wcd937x_dt_parse_micbias_info(dev, wcd937x);
@@ -2983,7 +2981,6 @@ static int wcd937x_probe(struct platform_device *pdev) 


err_disable_regulators:

	regulator_bulk_disable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies);

	regulator_bulk_free(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies);



	return ret;

}
@@ -3000,7 +2997,6 @@ static void wcd937x_remove(struct platform_device *pdev) 
	pm_runtime_dont_use_autosuspend(dev);



	regulator_bulk_disable(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies);

	regulator_bulk_free(WCD937X_MAX_BULK_SUPPLY, wcd937x->supplies);

}



#if defined(CONFIG_OF)