Commit 64b45dd4 authored by Dave Young's avatar Dave Young Committed by Ard Biesheuvel
Browse files

x86/efi: skip memattr table on kexec boot 

efi_memattr_init() added a sanity check to avoid firmware caused corruption.
The check is based on efi memmap entry numbers, but kexec only takes the
runtime related memmap entries thus this caused many false warnings, see
below thread for details:

https://lore.kernel.org/all/20250108215957.3437660-2-usamaarif642@gmail.com/



Ard suggests to skip the efi memattr table in kexec, this makes sense because
those memattr fixups are not critical.

Fixes: 8fbe4c49 ("efi/memattr: Ignore table if the size is clearly bogus")
Cc: <stable@vger.kernel.org> # v6.13+
Reported-by: default avatarBreno Leitao <leitao@debian.org>
Reported-and-tested-by: default avatarUsama Arif <usamaarif642@gmail.com>
Suggested-by: default avatarArd Biesheuvel <ardb@kernel.org>
Signed-off-by: default avatarDave Young <dyoung@redhat.com>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent b5d1e6ee

arch/x86/platform/efi/quirks.c

+5 −0
Original line number Diff line number Diff line
@@ -561,6 +561,11 @@ int __init efi_reuse_config(u64 tables, int nr_tables) 


		if (!efi_guidcmp(guid, SMBIOS_TABLE_GUID))

			((efi_config_table_64_t *)p)->table = data->smbios;



		/* Do not bother to play with mem attr table across kexec */

		if (!efi_guidcmp(guid, EFI_MEMORY_ATTRIBUTES_TABLE_GUID))

			((efi_config_table_64_t *)p)->table = EFI_INVALID_TABLE_ADDR;



		p += sz;

	}

	early_memunmap(tablep, nr_tables * sz);