Commit 64f37cd5 authored by Matti Vaittinen's avatar Matti Vaittinen Committed by Jakub Kicinski
Browse files

net: gianfar: Use device_get_named_child_node_count() 



We can avoid open-coding the loop construct which counts firmware child
nodes with a specific name by using the newly added
device_get_named_child_node_count().

The gianfar driver has such open-coded loop. Replace it with the
device_get_child_node_count_named().

Suggested-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarMatti Vaittinen <mazziesaccount@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/3a33988fc042588cb00a0bfc5ad64e749cb0eb1f.1750248902.git.mazziesaccount@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 39983de5

drivers/net/ethernet/freescale/gianfar.c

+4 −13
Original line number Diff line number Diff line
@@ -97,6 +97,7 @@ 
#include <linux/phy_fixed.h>

#include <linux/of.h>

#include <linux/of_net.h>

#include <linux/property.h>



#include "gianfar.h"
@@ -571,18 +572,6 @@ static int gfar_parse_group(struct device_node *np, 
	return 0;

}



static int gfar_of_group_count(struct device_node *np)

{

	struct device_node *child;

	int num = 0;



	for_each_available_child_of_node(np, child)

		if (of_node_name_eq(child, "queue-group"))

			num++;



	return num;

}



/* Reads the controller's registers to determine what interface

 * connects it to the PHY.

 */
@@ -654,8 +643,10 @@ static int gfar_of_init(struct platform_device *ofdev, struct net_device **pdev) 
		num_rx_qs = 1;

	} else { /* MQ_MG_MODE */

		/* get the actual number of supported groups */

		unsigned int num_grps = gfar_of_group_count(np);

		unsigned int num_grps;



		num_grps = device_get_named_child_node_count(&ofdev->dev,

							     "queue-group");

		if (num_grps == 0 || num_grps > MAXGROUPS) {

			dev_err(&ofdev->dev, "Invalid # of int groups(%d)\n",

				num_grps);