Commit 668d7167 authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio: light: bh1745: Stop using iio_device_claim_direct_scoped() 



This complex cleanup.h use case of conditional guards has proved
to be more trouble that it is worth in terms of false positive compiler
warnings and hard to read code.

Move directly to the new claim/release_direct() that allow sparse
to check for unbalanced context.

Reviewed-by: default avatarMudit Sharma <muditsharma.info@gmail.com>
Reviewed-by: default avatarDavid Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250209180624.701140-27-jic23@kernel.org


Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
parent 0bee1bf8

drivers/iio/light/bh1745.c

+9 −9
Original line number Diff line number Diff line
@@ -426,16 +426,16 @@ static int bh1745_read_raw(struct iio_dev *indio_dev, 


	switch (mask) {

	case IIO_CHAN_INFO_RAW:

		iio_device_claim_direct_scoped(return -EBUSY, indio_dev) {

			ret = regmap_bulk_read(data->regmap, chan->address,

					       &value, 2);

		if (!iio_device_claim_direct(indio_dev))

			return -EBUSY;



		ret = regmap_bulk_read(data->regmap, chan->address, &value, 2);

		iio_device_release_direct(indio_dev);

		if (ret)

			return ret;

		*val = value;



		return IIO_VAL_INT;

		}

		unreachable();



	case IIO_CHAN_INFO_SCALE: {

			guard(mutex)(&data->lock);