Commit 669f1f48 authored by Orlando Chamberlain's avatar Orlando Chamberlain Committed by Hans de Goede
Browse files

platform/x86: apple-gmux: don't use be32_to_cpu and cpu_to_be32 



Sparce doesn't seem to like using be32_to_cpu and cpu_to_be32 to convert
values for the MMIO gmux to/from the host architecture.

Instead use iowrite32be and ioread32be to always convert, which should be
fine because apple-gmux is only used on x86 with is always little endian.

Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202305161712.5l3f4iI4-lkp@intel.com/


Signed-off-by: default avatarOrlando Chamberlain <orlandoch.dev@gmail.com>
Link: https://lore.kernel.org/r/20230614064931.3263-2-orlandoch.dev@gmail.com


Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent 966cca72

drivers/platform/x86/apple-gmux.c

+2 −2
Original line number Diff line number Diff line
@@ -278,7 +278,7 @@ static u32 gmux_mmio_read32(struct apple_gmux_data *gmux_data, int port) 
	iowrite8(GMUX_MMIO_READ | sizeof(val),

		gmux_data->iomem_base + GMUX_MMIO_COMMAND_SEND);

	gmux_mmio_wait(gmux_data);

	val = be32_to_cpu(ioread32(gmux_data->iomem_base));

	val = ioread32be(gmux_data->iomem_base);

	mutex_unlock(&gmux_data->index_lock);



	return val;
@@ -288,7 +288,7 @@ static void gmux_mmio_write32(struct apple_gmux_data *gmux_data, int port, 
			       u32 val)

{

	mutex_lock(&gmux_data->index_lock);

	iowrite32(cpu_to_be32(val), gmux_data->iomem_base);

	iowrite32be(val, gmux_data->iomem_base);

	iowrite8(port & 0xff, gmux_data->iomem_base + GMUX_MMIO_PORT_SELECT);

	iowrite8(GMUX_MMIO_WRITE | sizeof(val),

		gmux_data->iomem_base + GMUX_MMIO_COMMAND_SEND);