Commit 6706ad56 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Jens Axboe
Browse files

bcache: movinggc: Use struct_size() helper in kzalloc() 



Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

This code was detected with the help of Coccinelle and, audited and
fixed manually.

Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarColy Li <colyli@suse.de>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 7236657c

drivers/md/bcache/movinggc.c

+2 −2
Original line number Diff line number Diff line
@@ -145,8 +145,8 @@ static void read_moving(struct cache_set *c) 
			continue;

		}



		io = kzalloc(sizeof(struct moving_io) + sizeof(struct bio_vec)

			     * DIV_ROUND_UP(KEY_SIZE(&w->key), PAGE_SECTORS),

		io = kzalloc(struct_size(io, bio.bio.bi_inline_vecs,

					 DIV_ROUND_UP(KEY_SIZE(&w->key), PAGE_SECTORS)),

			     GFP_KERNEL);

		if (!io)

			goto err;