Commit 67f10a10 authored by Filipe Manana's avatar Filipe Manana Committed by David Sterba
Browse files

btrfs: exit after state insertion failure at set_extent_bit() 



If insert_state() state failed it returns an error pointer and we call
extent_io_tree_panic() which will trigger a BUG() call. However if
CONFIG_BUG is disabled, which is an uncommon and exotic scenario, then
we fallthrough and call cache_state() which will dereference the error
pointer, resulting in an invalid memory access.

So jump to the 'out' label after calling extent_io_tree_panic(), it also
makes the code more clear besides dealing with the exotic scenario where
CONFIG_BUG is disabled.

Signed-off-by: default avatarFilipe Manana <fdmanana@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 0edc1a5c

fs/btrfs/extent-io-tree.c

+1 −0
Original line number Diff line number Diff line
@@ -1223,6 +1223,7 @@ static int set_extent_bit(struct extent_io_tree *tree, u64 start, u64 end, 
		if (IS_ERR(inserted_state)) {

			ret = PTR_ERR(inserted_state);

			extent_io_tree_panic(tree, prealloc, "insert", ret);

			goto out;

		}



		cache_state(inserted_state, cached_state);