Commit 686e905a authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

platform/x86/intel/vbtn: Stop creating a platform device 



Now that "system" devices are represented as platform devices, they
are not claimed by the PNP ACPI scan handler any more and the Intel
virtual button array platform devices should be created by the ACPI
core, so the driver does not need to attempt to create a platform
device by itself.

Accordingly, make it stop doing so.

No intentional functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: default avatarMario Limonciello (AMD) <superm1@kernel.org>
Link: https://patch.msgid.link/8661724.NyiUUSuA9g@rafael.j.wysocki
parent 61ddc929

drivers/platform/x86/intel/vbtn.c

+1 −29
Original line number Diff line number Diff line
@@ -390,32 +390,4 @@ static struct platform_driver intel_vbtn_pl_driver = { 
	.remove = intel_vbtn_remove,

};



static acpi_status __init

check_acpi_dev(acpi_handle handle, u32 lvl, void *context, void **rv)

{

	const struct acpi_device_id *ids = context;

	struct acpi_device *dev = acpi_fetch_acpi_dev(handle);



	if (dev && acpi_match_device_ids(dev, ids) == 0)

		if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))

			dev_info(&dev->dev,

				 "intel-vbtn: created platform device\n");



	return AE_OK;

}



static int __init intel_vbtn_init(void)

{

	acpi_walk_namespace(ACPI_TYPE_DEVICE, ACPI_ROOT_OBJECT,

			    ACPI_UINT32_MAX, check_acpi_dev, NULL,

			    (void *)intel_vbtn_ids, NULL);



	return platform_driver_register(&intel_vbtn_pl_driver);

}

module_init(intel_vbtn_init);



static void __exit intel_vbtn_exit(void)

{

	platform_driver_unregister(&intel_vbtn_pl_driver);

}

module_exit(intel_vbtn_exit);
 
module_platform_driver(intel_vbtn_pl_driver);