Commit 6896c244 authored by Tiezhu Yang's avatar Tiezhu Yang Committed by Jakub Kicinski
Browse files

net: stmmac: Check stmmac_hw_setup() in stmmac_resume() 



stmmac_hw_setup() may return 0 on success and an appropriate negative
integer as defined in errno.h file on failure, just check it and then
return early if failed in stmmac_resume().

Signed-off-by: default avatarTiezhu Yang <yangtiezhu@loongson.cn>
Reviewed-by: default avatarMaxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: default avatarHuacai Chen <chenhuacai@loongson.cn>
Link: https://patch.msgid.link/20250811073506.27513-2-yangtiezhu@loongson.cn


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent fdbe93b7

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+8 −1
Original line number Diff line number Diff line
@@ -7984,7 +7984,14 @@ int stmmac_resume(struct device *dev) 
	stmmac_free_tx_skbufs(priv);

	stmmac_clear_descriptors(priv, &priv->dma_conf);



	stmmac_hw_setup(ndev, false);

	ret = stmmac_hw_setup(ndev, false);

	if (ret < 0) {

		netdev_err(priv->dev, "%s: Hw setup failed\n", __func__);

		mutex_unlock(&priv->lock);

		rtnl_unlock();

		return ret;

	}



	stmmac_init_coalesce(priv);

	phylink_rx_clk_stop_block(priv->phylink);

	stmmac_set_rx_mode(ndev);