Commit 689b5a80 authored by Kiran K's avatar Kiran K Committed by Luiz Augusto von Dentz
Browse files

Bluetooth: btintel_pcie: Do not generate coredump for diagnostic events 



All Intel diagnostic events are part of HCI traces and there is no need
to generate coredump for the same.

Signed-off-by: default avatarKiran K <kiran.k@intel.com>
Signed-off-by: default avatarLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
parent bbf56029

drivers/bluetooth/btintel.c

+1 −2
Original line number Diff line number Diff line
@@ -3688,7 +3688,7 @@ int btintel_configure_setup(struct hci_dev *hdev, const char *driver_name) 
}

EXPORT_SYMBOL_GPL(btintel_configure_setup);



int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb)

static int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb)

{

	struct intel_tlv *tlv = (void *)&skb->data[5];
@@ -3716,7 +3716,6 @@ int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb) 
recv_frame:

	return hci_recv_frame(hdev, skb);

}

EXPORT_SYMBOL_GPL(btintel_diagnostics);



int btintel_recv_event(struct hci_dev *hdev, struct sk_buff *skb)

{

drivers/bluetooth/btintel.h

+0 −6
Original line number Diff line number Diff line
@@ -277,7 +277,6 @@ int btintel_bootloader_setup_tlv(struct hci_dev *hdev, 
int btintel_shutdown_combined(struct hci_dev *hdev);

void btintel_hw_error(struct hci_dev *hdev, u8 code);

void btintel_print_fseq_info(struct hci_dev *hdev);

int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb);

#else



static inline int btintel_check_bdaddr(struct hci_dev *hdev)
@@ -411,9 +410,4 @@ static inline void btintel_hw_error(struct hci_dev *hdev, u8 code) 
static inline void btintel_print_fseq_info(struct hci_dev *hdev)

{

}



static inline int btintel_diagnostics(struct hci_dev *hdev, struct sk_buff *skb)

{

	return -EOPNOTSUPP;

}

#endif

drivers/bluetooth/btintel_pcie.c

+0 −10
Original line number Diff line number Diff line
@@ -889,7 +889,6 @@ static void btintel_pcie_msix_tx_handle(struct btintel_pcie_data *data) 
static int btintel_pcie_recv_event(struct hci_dev *hdev, struct sk_buff *skb)

{

	struct hci_event_hdr *hdr = (void *)skb->data;

	const char diagnostics_hdr[] = { 0x87, 0x80, 0x03 };

	struct btintel_pcie_data *data = hci_get_drvdata(hdev);



	if (skb->len > HCI_EVENT_HDR_SIZE && hdr->evt == 0xff &&
@@ -945,15 +944,6 @@ static int btintel_pcie_recv_event(struct hci_dev *hdev, struct sk_buff *skb) 
			}

		}



		/* Handle all diagnostics events separately. May still call

		 * hci_recv_frame.

		 */

		if (len >= sizeof(diagnostics_hdr) &&

		    memcmp(&skb->data[2], diagnostics_hdr,

			   sizeof(diagnostics_hdr)) == 0) {

			return btintel_diagnostics(hdev, skb);

		}



		/* This is a debug event that comes from IML and OP image when it

		 * starts execution. There is no need pass this event to stack.

		 */