Commit 68a13501 authored by Mark Harmstone's avatar Mark Harmstone Committed by David Sterba
Browse files

btrfs: fix bytes_may_use leak in move_existing_remap() 



If the call to btrfs_reserve_extent() in move_existing_remap() returns a
smaller extent than we asked for, currently we're not undoing the
bytes_may_use change that we made. Fix this by calling
btrfs_space_info_update_bytes_may_use() again for the difference.

Fixes: bbea42df ("btrfs: move existing remaps before relocating block group")
Reviewed-by: default avatarBoris Burkov <boris@bur.io>
Signed-off-by: default avatarMark Harmstone <mark@harmstone.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent fc3d5328

fs/btrfs/relocation.c

+6 −0
Original line number Diff line number Diff line
@@ -4174,6 +4174,12 @@ static int move_existing_remap(struct btrfs_fs_info *fs_info, 
		return ret;

	}



	if (ins.offset < length) {

		spin_lock(&sinfo->lock);

		btrfs_space_info_update_bytes_may_use(sinfo, ins.offset - length);

		spin_unlock(&sinfo->lock);

	}



	dest_addr = ins.objectid;

	dest_length = ins.offset;