Commit 6a1d796e authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

leds: bcm6328: Simplify with scoped for each OF child loop 



Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-var-v1-7-1d0292802470@linaro.org


Signed-off-by: default avatarLee Jones <lee@kernel.org>
parent 073f0165

drivers/leds/leds-bcm6328.c

+2 −5
Original line number Diff line number Diff line
@@ -392,7 +392,6 @@ static int bcm6328_leds_probe(struct platform_device *pdev) 
{

	struct device *dev = &pdev->dev;

	struct device_node *np = dev_of_node(&pdev->dev);

	struct device_node *child;

	void __iomem *mem;

	spinlock_t *lock; /* memory lock */

	unsigned long val, *blink_leds, *blink_delay;
@@ -435,7 +434,7 @@ static int bcm6328_leds_probe(struct platform_device *pdev) 
		val |= BCM6328_SERIAL_LED_SHIFT_DIR;

	bcm6328_led_write(mem + BCM6328_REG_INIT, val);



	for_each_available_child_of_node(np, child) {

	for_each_available_child_of_node_scoped(np, child) {

		int rc;

		u32 reg;
@@ -454,11 +453,9 @@ static int bcm6328_leds_probe(struct platform_device *pdev) 
			rc = bcm6328_led(dev, child, reg, mem, lock,

					 blink_leds, blink_delay);



		if (rc < 0) {

			of_node_put(child);

		if (rc < 0)

			return rc;

	}

	}



	return 0;

}