Commit 6a7bd6cd authored by Douglas Anderson's avatar Douglas Anderson Committed by Neil Armstrong
Browse files

drm/panel: ilitek-ili9882t: Check for errors on the NOP in prepare() 



The mipi_dsi_dcs_nop() function returns an error but we weren't
checking it in ili9882t_prepare(). Add a check. This is highly
unlikely to matter in practice. If the NOP failed then likely later
MIPI commands would fail too.

Found by code inspection.

Fixes: e2450d32 ("drm/panel: ili9882t: Break out as separate driver")
Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Reviewed-by: default avatarDmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/20240517143643.5.I323476ba9fa8cc7a5adee4c1ec95202785cc5686@changeid


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240517143643.5.I323476ba9fa8cc7a5adee4c1ec95202785cc5686@changeid
parent 554c0018

drivers/gpu/drm/panel/panel-ilitek-ili9882t.c

+5 −1
Original line number Diff line number Diff line
@@ -478,7 +478,11 @@ static int ili9882t_prepare(struct drm_panel *panel) 
	usleep_range(10000, 11000);



	// MIPI needs to keep the LP11 state before the lcm_reset pin is pulled high

	mipi_dsi_dcs_nop(ili->dsi);

	ret = mipi_dsi_dcs_nop(ili->dsi);

	if (ret < 0) {

		dev_err(&ili->dsi->dev, "Failed to send NOP: %d\n", ret);

		goto poweroff;

	}

	usleep_range(1000, 2000);



	gpiod_set_value(ili->enable_gpio, 1);