Commit 6a985607 authored by Ville Syrjälä's avatar Ville Syrjälä
Browse files

drm/i915: Generalize planes_{enabling,disabling}() 



I want to use the same logic that planes_{enabling,disabling}()
are using for other features as well. Generlize the thing
into a pair of macros.

Signed-off-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230320203352.19515-2-ville.syrjala@linux.intel.com


Reviewed-by: default avatarMitul Golani <mitulkumar.ajitkumar.golani@intel.com>
parent 1bf38363

drivers/gpu/drm/i915/display/intel_display.c

+12 −4
Original line number Diff line number Diff line
@@ -1069,20 +1069,28 @@ static bool needs_async_flip_vtd_wa(const struct intel_crtc_state *crtc_state) 
		(DISPLAY_VER(i915) == 9 || IS_BROADWELL(i915) || IS_HASWELL(i915));

}



#define is_enabling(feature, old_crtc_state, new_crtc_state) \

	((!(old_crtc_state)->feature || intel_crtc_needs_modeset(new_crtc_state)) && \

	 (new_crtc_state)->feature)

#define is_disabling(feature, old_crtc_state, new_crtc_state) \

	((old_crtc_state)->feature && \

	 (!(new_crtc_state)->feature || intel_crtc_needs_modeset(new_crtc_state)))



static bool planes_enabling(const struct intel_crtc_state *old_crtc_state,

			    const struct intel_crtc_state *new_crtc_state)

{

	return (!old_crtc_state->active_planes || intel_crtc_needs_modeset(new_crtc_state)) &&

		new_crtc_state->active_planes;

	return is_enabling(active_planes, old_crtc_state, new_crtc_state);

}



static bool planes_disabling(const struct intel_crtc_state *old_crtc_state,

			     const struct intel_crtc_state *new_crtc_state)

{

	return old_crtc_state->active_planes &&

		(!new_crtc_state->active_planes || intel_crtc_needs_modeset(new_crtc_state));

	return is_disabling(active_planes, old_crtc_state, new_crtc_state);

}



#undef is_disabling

#undef is_enabling



static void intel_post_plane_update(struct intel_atomic_state *state,

				    struct intel_crtc *crtc)

{