Commit 6b606216 authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/amd/ras: Fix NULL deref in ras_core_ras_interrupt_detected() 



Fixes a NULL pointer dereference when ras_core is NULL and ras_core->dev
is accessed in the error path.

Fixes: 13c91b5b ("drm/amd/ras: Add rascore unified interface function")
Reported by: Dan Carpenter <dan.carpenter@linaro.org>
Cc: YiPeng Chai <YiPeng.Chai@amd.com>
Cc: Tao Zhou <tao.zhou1@amd.com>
Cc: Hawking Zhang <Hawking.Zhang@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Reviewed-by: default avatarTao Zhou <tao.zhou1@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent a782576e

drivers/gpu/drm/amd/ras/rascore/ras_core.c

+3 −1
Original line number Diff line number Diff line
@@ -550,7 +550,9 @@ bool ras_core_ras_interrupt_detected(struct ras_core_context *ras_core) 
		ras_core->sys_fn->detect_ras_interrupt)

		return ras_core->sys_fn->detect_ras_interrupt(ras_core);



	if (ras_core && ras_core->dev)

		RAS_DEV_ERR(ras_core->dev, "Failed to detect ras interrupt!\n");



	return false;

}