Commit 6c454270 authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

ipv6: Use nlmsg_payload in addrconf file 



Leverage the new nlmsg_payload() helper to avoid checking for message
size and then reading the nlmsg data.

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250415-nlmsg_v2-v1-2-a1c75d493fd7@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 5ef4097e

net/ipv6/addrconf.c

+2 −2
Original line number Diff line number Diff line
@@ -6112,7 +6112,8 @@ static int inet6_valid_dump_ifinfo(const struct nlmsghdr *nlh, 
{

	struct ifinfomsg *ifm;



	if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*ifm))) {

	ifm = nlmsg_payload(nlh, sizeof(*ifm));

	if (!ifm) {

		NL_SET_ERR_MSG_MOD(extack, "Invalid header for link dump request");

		return -EINVAL;

	}
@@ -6122,7 +6123,6 @@ static int inet6_valid_dump_ifinfo(const struct nlmsghdr *nlh, 
		return -EINVAL;

	}



	ifm = nlmsg_data(nlh);

	if (ifm->__ifi_pad || ifm->ifi_type || ifm->ifi_flags ||

	    ifm->ifi_change || ifm->ifi_index) {

		NL_SET_ERR_MSG_MOD(extack, "Invalid values in header for dump request");