Unverified Commit 6c9e64e8 authored by Dan Carpenter's avatar Dan Carpenter Committed by Rodrigo Vivi
Browse files

drm/xe: Fix an IS_ERR() vs NULL bug in xe_tile_alloc_vram() 



The xe_vram_region_alloc() function returns NULL on error.  It never
returns error pointers.  Update the error checking to match.

Fixes: 4b0a5f5c ("drm/xe: Unify the initialization of VRAM regions")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/5449065e-9758-4711-b706-78771c0753c4@sabinyo.mountain


Reviewed-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: default avatarRodrigo Vivi <rodrigo.vivi@intel.com>
parent 4b5514f7

drivers/gpu/drm/xe/xe_tile.c

+2 −2
Original line number Diff line number Diff line
@@ -120,8 +120,8 @@ int xe_tile_alloc_vram(struct xe_tile *tile) 
		return 0;



	vram = xe_vram_region_alloc(xe, tile->id, XE_PL_VRAM0 + tile->id);

	if (IS_ERR(vram))

		return PTR_ERR(vram);

	if (!vram)

		return -ENOMEM;

	tile->mem.vram = vram;



	return 0;