Commit 6ca27381 authored by Jarkko Nikula's avatar Jarkko Nikula Committed by Alexandre Belloni
Browse files

i3c: mipi-i3c-hci: Mask ring interrupts before ring stop request 



Bus cleanup path in DMA mode may trigger a RING_OP_STAT interrupt when
the ring is being stopped. Depending on timing between ring stop request
completion, interrupt handler removal and code execution this may lead
to a NULL pointer dereference in hci_dma_irq_handler() if it gets to run
after the io_data pointer is set to NULL in hci_dma_cleanup().

Prevent this my masking the ring interrupts before ring stop request.

Signed-off-by: default avatarJarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20240920144432.62370-2-jarkko.nikula@linux.intel.com


Signed-off-by: default avatarAlexandre Belloni <alexandre.belloni@bootlin.com>
parent 30829905

drivers/i3c/master/mipi-i3c-hci/dma.c

+1 −1
Original line number Diff line number Diff line
@@ -159,10 +159,10 @@ static void hci_dma_cleanup(struct i3c_hci *hci) 
	for (i = 0; i < rings->total; i++) {

		rh = &rings->headers[i];



		rh_reg_write(INTR_SIGNAL_ENABLE, 0);

		rh_reg_write(RING_CONTROL, 0);

		rh_reg_write(CR_SETUP, 0);

		rh_reg_write(IBI_SETUP, 0);

		rh_reg_write(INTR_SIGNAL_ENABLE, 0);



		if (rh->xfer)

			dma_free_coherent(&hci->master.dev,