Commit 6ccfe1e3 authored by Hans Verkuil's avatar Hans Verkuil
Browse files

staging: media: atomisp: drop check for reentrant .s_stream() 



The subdev .s_stream() operation shall not be called to start streaming
on an already started subdev, or stop streaming on a stopped subdev.
Remove the check that guards against that condition.

Also fixes a smatch warning:

drivers/staging/media/atomisp/i2c/atomisp-gc0310.c:446 gc0310_s_stream() warn: missing error code 'ret'

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
CC: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
parent a1766a4f

drivers/staging/media/atomisp/i2c/atomisp-gc0310.c

+0 −6
Original line number Diff line number Diff line
@@ -441,11 +441,6 @@ static int gc0310_s_stream(struct v4l2_subdev *sd, int enable) 
	dev_dbg(&client->dev, "%s S enable=%d\n", __func__, enable);

	mutex_lock(&dev->input_lock);



	if (dev->is_streaming == enable) {

		dev_warn(&client->dev, "stream already %s\n", enable ? "started" : "stopped");

		goto error_unlock;

	}



	if (enable) {

		ret = pm_runtime_get_sync(&client->dev);

		if (ret < 0)
@@ -497,7 +492,6 @@ static int gc0310_s_stream(struct v4l2_subdev *sd, int enable) 
error_power_down:

	pm_runtime_put(&client->dev);

	dev->is_streaming = false;

error_unlock:

	mutex_unlock(&dev->input_lock);

	return ret;

}